Merge xcode10 into d15-9 by VincentDondain · Pull Request #4820 · dotnet/macios

VincentDondain · 2018-09-14T17:38:28Z

Bump maccore that has a bump of maciostool that's using Xamarin.MacDev's d15-9 branch.
No need for extra dependency bumps : Xamarin.MacDev in xamarin-macios was already using d15-9 which is equivalent to xcode10 and machos-binaries's d15-9 branch is equivalent to xcode10 too.

Note: tools/common/Frameworks.cs required a bit more work than other files, it's a fusion of 9f90691 and 215ab7f.

- Work around dotnet#4441 by commenting out binding until fixed

* [PDFKit] Update bindings to Xcode 10 Beta 1, 2 & 3 * Removes redundant availability attrib and fixes PDFKit library mapping case in xtro

…otnet#4443) Allso adds UIKit UIWebView deprecations

* [PassKit] Added support for Xcode 10 up to beta 3. * Minor style changes.

This used to be a calculated macro and got promoted to a field in macOS 10.13

…rt for DispatchData on bindings API

…ad of NetworkLibrary

…d closes connection

…ssed in the callback is null

…mpilation issues

This reverts commit 53fdc01. Unfortunately there is not enough info for the AOT compiler to handle MidiCIDeviceIdentification struct and this is causing mtouch tests to fail

…o do some of the block-callback heavy lifting

Bump for Xcode 10 beta 4

- Only on macOS - Only a subset of the uses are deprecated, see radar://42257568

…pple (dotnet#4474)

* [Contacts] Update bindings to Xcode 10 Beta 4 * Fix typo

…otnet#4783)

…r API with unit tests (dotnet#4784)

…otnet#4786) This means less (duplicated) manual code, which means less errors, which also means we're now getting some new members that previously weren't duplicated correctly. Fixes dotnet#4183.

* Avoid `ArgumentNullException` in default/empty `SecProtocolMetadata.PeerPublicKey` * Add two `SecProtocolMetadata.CreateSecret` API - disabled as the current tests (incomplete?) crash in unit tests * Add basic unit tests for `[Sec|NW]ProtocolMetadata` * Update xtro

…sts. (dotnet#4793)

Note that it included 173 new API so xtro files were updated to - include new API in .todo - add some backlog to .ignore files

spouliot · 2018-09-14T17:43:09Z

Make.config

+IOS_PACKAGE_VERSION=12.2.$(PACKAGE_VERSION_REV).$(IOS_COMMIT_DISTANCE)
 IOS_PACKAGE_VERSION_MAJOR=$(word 1, $(subst ., ,$(IOS_PACKAGE_VERSION)))
 IOS_PACKAGE_VERSION_MINOR=$(word 2, $(subst ., ,$(IOS_PACKAGE_VERSION)))
-IOS_PACKAGE_VERSION_REV=$(PACKAGE_VERSION_REV)


that's used afterward

monojenkins · 2018-09-14T22:06:16Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
🔥 Test run failed 🔥

Test results

1 tests failed, 0 tests skipped, 218 tests passed.

Failed tests

monotouch-test/tvOS - simulator/Release (all optimizations): Failed

rolfbjarne · 2018-09-17T07:08:07Z

docs/website/Makefile

@@ -1,21 +1,23 @@
 TOP=../../..
-WEBSITE_DOCS ?= $(TOP)/documentation
+WEBSITE_DOCS ?= $(TOP)/xamarin-docs-pr


@spouliot these docs changes were made in d15-7 (PR #3771), and are here because we branched the xcode10 branch from d15-7.

This means d15-8 does not have these changes (nor does master (yet)). Was that intentional?

Since we only merge those from a release branch I think it was fine (for 15.7) but it should have been merged (last Xcode) back into master. Not a big deal since we need to update that process soon anyway.

rolfbjarne · 2018-09-17T07:10:54Z

docs/website/mmp-errors.md


-If this is not the case, please file a bug at [https://bugzilla.xamarin.com](https://bugzilla.xamarin.com/enter_bug.cgi?product=Xamarin.Mac) with a test case.
-
-### <a name="MM4175"/>MM4175: The parameter '{parameter}' in the method '{method}' has an invalid BlockProxy attribute (the type passed to the attribute does not have a 'Create' method).


The text for MM4175 shouldn't be deleted.

rolfbjarne · 2018-09-17T07:12:57Z

docs/website/mtouch-errors.md

-
-This warning can most likely be ignored; in case of any problems file a bug (https://bugzilla.xamarin.com](https://bugzilla.xamarin.com/enter_bug.cgi?product=iOS)) and it will be investigated.
-
-### <a name="MT0129"/>MT0129: Debugging symbol file for '*' does not match the assembly and is ignored.


The text for MT0129-MT0134 shouldn't be gone.

monojenkins · 2018-09-17T17:54:38Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
🔥 Test run failed 🔥

Test results

1 tests failed, 0 tests skipped, 218 tests passed.

Failed tests

monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed

VincentDondain · 2018-09-17T18:06:09Z

Test failure is a known issue: https://github.com/xamarin/maccore/issues/1026

chamons and others added 30 commits July 13, 2018 14:27

Foundation for Xcode 10 Beta 1-2 (dotnet#4375)

6d039cb

- Work around dotnet#4441 by commenting out binding until fixed

[PDFKit] Update bindings to Xcode 10 Beta 1, 2 & 3 (dotnet#4439)

e944b58

* [PDFKit] Update bindings to Xcode 10 Beta 1, 2 & 3 * Removes redundant availability attrib and fixes PDFKit library mapping case in xtro

[WebKit] Update bindings to Xcode 10 Beta 1, Nothing on beta 2 or 3 (d…

38bbffd

…otnet#4443) Allso adds UIKit UIWebView deprecations

[PassKit] Added support for Xcode 10 up to beta 3. (dotnet#4423)

db62640

* [PassKit] Added support for Xcode 10 up to beta 3. * Minor style changes.

[PDFkit] Fix kPDFDestinationUnspecifiedValue availability (dotnet#4444)

e131be9

This used to be a calculated macro and got promoted to a field in macOS 10.13

[CoreFondation] Introduce bindings for DispatchIO, add upcoming suppo…

3c3736e

…rt for DispatchData on bindings API

[Security] Fix P/Invoke signatures to reference SecurityLibrary inste…

953ece7

…ad of NetworkLibrary

[Network] add convenience overload, and fix scenarios where remote en…

00048ee

…d closes connection

[CoreFoundation] DispatchIO, handle scenarios where the data being pa…

5252b99

…ssed in the callback is null

[Network, Security] Typo fixes

7bfb265

[CoreMidi] Xcode 10 beta 3 update. (dotnet#4453)

53fdc01

Bump for Xcode 10 beta 4

c197102

Temporarily bump the MIN_OSX_SDK_VERSION to 10.9 to avoid SceneKit co…

63a4f19

…mpilation issues

Update min macOS version in Versions-mac.plist

0fdcd45

More 10.7 -> 10.9 bumps

24a4360

Bump tests minimum version from 10.7 to 10.9

acc5890

[TVMLKit] Update bindings to Xcode 10 Beta 4

95705d5

[tests] Fix introspection tests in macOS 10.13

035fed8

[CFNetwork] Xcode 10 beta 3 update. (dotnet#4454)

752083a

[xharness] Fix simulator hangs in our tests

313cb7d

Revert "[CoreMidi] Xcode 10 beta 3 update. (dotnet#4453)"

9bf520f

This reverts commit 53fdc01. Unfortunately there is not enough info for the AOT compiler to handle MidiCIDeviceIdentification struct and this is causing mtouch tests to fail

[generator, Network] Move towards actually supporting the generator t…

8c53baa

…o do some of the block-callback heavy lifting

[Security, Network] address issues found by automatic instance creation

7207e1e

Merge pull request dotnet#4459 from dalexsoto/Xcode10-Beta4

2d1a314

Bump for Xcode 10 beta 4

Initial OpenGL deprecation (dotnet#4458)

045dda9

- Only on macOS - Only a subset of the uses are deprecated, see radar://42257568

Remove comment for 41367075 as header change verified as mistake by A…

1f3ec64

…pple (dotnet#4474)

[Contacts] Update bindings to Xcode 10 Beta 4 (dotnet#4475)

1fd13ff

* [Contacts] Update bindings to Xcode 10 Beta 4 * Fix typo

[AVFAudio] Update binding to Xcode 10 Beta 4 (dotnet#4476)

2b7aaba

[CoreML] Update bindings to Xcode 10 Beta 4 (dotnet#4477)

5a8ad7e

[CoreMotion] Update to Xcode 10 Beta 4 (dotnet#4478)

9f238a0

spouliot and others added 9 commits September 11, 2018 08:41

[security] Fix 'SecCertificate2.Certificate' call and add some tests (d…

46fb26e

…otnet#4783)

[security] Add new SecCertificateCopyKey and SecTrustEvaluateWithErro…

6af77f3

…r API with unit tests (dotnet#4784)

[Tests] Add missing tests for NWPath. (dotnet#4765)

e43ca08

[HealthKit] Use generated NSString-backed enums. Fixes dotnet#4183. (d…

239d903

…otnet#4786) This means less (duplicated) manual code, which means less errors, which also means we're now getting some new members that previously weren't duplicated correctly. Fixes dotnet#4183.

[Tests] Add missing tests for NWProtocolStack and fix NWParameters te…

bed3770

…sts. (dotnet#4793)

Bump for Xcode10 GM (dotnet#4794)

aa622c4

Note that it included 173 new API so xtro files were updated to - include new API in .todo - add some backlog to .ignore files

Merge branch 'xcode10' into d15-9-merge-xcode10

91a52a1

Bump maccore

156c317

VincentDondain requested review from chamons, rolfbjarne and spouliot September 14, 2018 17:38

VincentDondain requested review from dalexsoto, emaf, jstedfast, kzu and mandel-macaque as code owners September 14, 2018 17:38

spouliot approved these changes Sep 14, 2018

View reviewed changes

emaf approved these changes Sep 14, 2018

View reviewed changes

rolfbjarne requested changes Sep 17, 2018

View reviewed changes

Fix d15-9 merge issues

436c933

rolfbjarne approved these changes Sep 17, 2018

View reviewed changes

jstedfast approved these changes Sep 17, 2018

View reviewed changes

emaf approved these changes Sep 17, 2018

View reviewed changes

rolfbjarne added this to the d15-9 milestone Sep 17, 2018

VincentDondain merged commit f06f159 into dotnet:d15-9 Sep 17, 2018

VincentDondain deleted the d15-9-merge-xcode10 branch September 17, 2018 19:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge xcode10 into d15-9#4820

Merge xcode10 into d15-9#4820
VincentDondain merged 555 commits intodotnet:d15-9from
VincentDondain:d15-9-merge-xcode10

VincentDondain commented Sep 14, 2018

Uh oh!

spouliot Sep 14, 2018

Uh oh!

monojenkins commented Sep 14, 2018

Failed tests

Uh oh!

rolfbjarne Sep 17, 2018

Uh oh!

spouliot Sep 17, 2018

Uh oh!

rolfbjarne Sep 17, 2018

Uh oh!

rolfbjarne Sep 17, 2018

Uh oh!

monojenkins commented Sep 17, 2018

Failed tests

Uh oh!

VincentDondain commented Sep 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants


		If this is not the case, please file a bug at [https://bugzilla.xamarin.com](https://bugzilla.xamarin.com/enter_bug.cgi?product=Xamarin.Mac) with a test case.

		### <a name="MM4175"/>MM4175: The parameter '{parameter}' in the method '{method}' has an invalid BlockProxy attribute (the type passed to the attribute does not have a 'Create' method).


		This warning can most likely be ignored; in case of any problems file a bug (https://bugzilla.xamarin.com](https://bugzilla.xamarin.com/enter_bug.cgi?product=iOS)) and it will be investigated.

		### <a name="MT0129"/>MT0129: Debugging symbol file for '*' does not match the assembly and is ignored.

Conversation

VincentDondain commented Sep 14, 2018

Uh oh!

spouliot Sep 14, 2018

Choose a reason for hiding this comment

Uh oh!

monojenkins commented Sep 14, 2018

Test results

Failed tests

Uh oh!

rolfbjarne Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

spouliot Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

monojenkins commented Sep 17, 2018

Test results

Failed tests

Uh oh!

VincentDondain commented Sep 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants